User submissions to code

We are using your EmonPI and EmonTX devices to monitor nearly all of our house circuits, and I think the project is great.
I would like to contribute some changes to the code, but I've never used github before.
Do you allow user submissions for changes?

For example, There's 3 I'd like to submit.
1. A change to /var/www/emoncms/Modules/vis/multigraph_edit.js to add a "tooltip" to explain what "Floating Time" means, as it wasn't obvious to me.
2. To change the /var/www/emoncms/Modules/user/user_model.php to make both the wrong username and wrong password messages the same (our box is on the internet, so I don't want to give too much information away!)

3. Change /var/www/emoncms/Modules/dashboard/Views/js/widgets/vis/vis_render.js "Mid", which doesn't mean much to "Multigraph number", and also list the multigraph name and not just the number, but I've not figured that bit out!

Maybe #2 needs to be a flag somewhere in the config to "harden" the installation, as I guess the original errors are useful for forgetful people :)

I've amended all 3 on our system without problems.

Thanks.

Paul Reed's picture

Re: User submissions to code

Yes, create a git fork of the emoncms repository, edit with your suggested changes, and submit a pull request to T&G.
They will review your changes and if they agree, they will merge the code into emoncms.
I've done the same several times, some accepted, some not, but looking at your suggestions, they would hopefully be gratefully received.  

Paul

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.