Archived Forum

Hello, 

I had some troubles with negative spikes on odd occasions (even with checks on my sketches and such) and wanted to know if it would be a bad idea to simply change the input_controller.php file and add a check that ignores data below a set value?

I made some adjustments to the .php already (the bold section) and it seems to work fine, below are the changes i made to the if($datain!="") function. 

i don't need values below 200 anyways and i don't feel like having to remove the spikes every now and then. Also would i be possible for me to create a process for the input that only allows values between two points to make changes to logged feeds? i'm kinda new to all this stuff :P 

if ($datain!="")
            {
                $json = preg_replace('/[^\w\s-.:,]/','',$datain);
                $datapairs = explode(',', $json);

                $csvi = 0;
                for ($i=0; $i<count($datapairs); $i++)
                {
                    $keyvalue = explode(':', $datapairs[$i]);

                    if (isset($keyvalue[1])) {
                        if ($keyvalue[0]=='') {$valid = false; $error = "Format error, json key missing or invalid character"; }
                        if (!is_numeric($keyvalue[1])) {$valid = false; $error = "Format error, json value is not numeric"; }
                        $data[$keyvalue[0]] = (float) $keyvalue[1];
                    } else {
                        if (!is_numeric($keyvalue[0])) {$valid = false; $error = "Format error: csv value is not numeric"; }
                        $data[$csvi+1] = (float) $keyvalue[0];
                        $csvi ++;
                    }
                }

                $userid = $session['userid'];
                $dbinputs = $input->get_inputs($userid);

                $tmp = array();
                foreach ($data as $name => $value)
                {

                if ($value < -200)
                {
                 $valid = false; 
                
                 $error = "Bad Data Recieved";
                }

                else
{

                    if (!isset($dbinputs[$nodeid][$name])) {
                        $inputid = $input->create_input($userid, $nodeid, $name);
                        $dbinputs[$nodeid][$name] = true;
                        $dbinputs[$nodeid][$name] = array('id'=>$inputid);
                        $input->set_timevalue($dbinputs[$nodeid][$name]['id'],$time,$value);
                    } else {
                        $inputid = $dbinputs[$nodeid][$name]['id'];
                        $input->set_timevalue($dbinputs[$nodeid][$name]['id'],$time,$value);

                        if ($dbinputs[$nodeid][$name]['processList']) $tmp[] = array('value'=>$value,'processList'=>$dbinputs[$nodeid][$name]['processList']);
                    }
                }}

                foreach ($tmp as $i) $process->input($time,$i['value'],$i['processList']);
            }
            else
            {
                $valid = false; $error = "Request contains no data via csv, json or data tag";
            }

            if ($valid)
                $result = 'ok';
            else
                $result = "Error: $error\n";
        }