json input list api needs rw apikey

Hi All

Is there any reason why the /input/list.json api needs the rw api key and not just the read-only api key? I was hoping not to have to embed the rw key in my software and I need the input values accessed by id.

For me, using the ro api key just returns false whereas the rw key returns the input list as expected.

[emoncms 8.4.0]

Thanks

Mike

pb66's picture

Re: json input list api needs rw apikey

I think it just got grouped in with other api's that must have write permission

​the permissions are checked in this line

​https://github.com/emoncms/emoncms/blob/master/Modules/input/input_controller.php#L22

and the "list" api is further down 

https://github.com/emoncms/emoncms/blob/master/Modules/input/input_controller.php#L300

​It maybe a lot of work to separate it, PHP is not my strong point but maybe you could add a sort of "or if 'json.list' and read permission set" after the exisiting write pwermission check as a sort of exception case if it's important to you ???

Paul

 

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.